[PATCH 1/2] fix indentation.

Jeroen Roovers jer at xs4all.nl
Mon Dec 7 00:32:53 EST 2020


On Fri,  4 Dec 2020 17:40:27 +0300
Alexander Nickulin <anikulin at dlink.ru> wrote:

> diff --git a/lib/netfilter/exp.c b/lib/netfilter/exp.c
> index 9cfdd2b..15d6fb7 100644
> --- a/lib/netfilter/exp.c
> +++ b/lib/netfilter/exp.c
> @@ -350,10 +350,10 @@ static int nfnl_exp_build_tuple(struct nl_msg
> *msg, const struct nfnl_exp *exp, 
>  	int type = exp_get_tuple_attr(cta);
>  
> -    if (cta == CTA_EXPECT_NAT)
> -        tuple = nla_nest_start(msg, CTA_EXPECT_NAT_TUPLE);
> -    else
> -        tuple = nla_nest_start(msg, cta);
> +	if (cta == CTA_EXPECT_NAT)

You are replacing spaces with tabs there. Not sure which coding style
is preferred in this project, but I guess you should follow the style
already used, which from looking at your patch's included context only
appears to be of the four-spaces persuasion and not tab characters.


Kind regards,
     jer



More information about the libnl mailing list