icalfileset_fetch

[libical at esumsoft.com]

Hi Allen,

Thanks for looking into this.  I've been looking at the sample code (also, progress.c, which seems to use icalfileset_fetch in the same manner; that is, using the result with icalclassify).  The sample returns -- and expects -- the parent component (vcalendar) for the requested uid, so I guess that's the intended behavior.

It still seems strange to me, but since that's the only available function that seems related to what I wanted to do, I'll just continue to use my own slight modification of the function -- no big deal.

Thanks for your help and support of this library, it's really appreciated.

Jeff


----- Original Message -----
From: Allen Winter <winter at kde.org>
To: libical-devel at lists.infradead.org
Cc: libical at esumsoft.com
Date: Thu, 18 Feb 2016 15:14:20 -0500
Subject: Re: icalfileset_fetch

> On Thursday, February 18, 2016 01:02:47 PM libical at esumsoft.com wrote:
> > Hi,
> > 
> > I just started using libical (v2.0.0) a couple of days ago, so I'm still getting a feel for it, but I came across some questionable behavior.
> > 
> > In the function icalfileset_fetch() (icalfileset.c) the value returned is "this" but shouldn't it be "inner" ?
> > 
> > That is, instead of:
> >                 if (strcmp(uid, this_uid) == 0) {
> >                     return this;
> >                 }
> > 
> > It should be:
> >                 if (strcmp(uid, this_uid) == 0) {
> >                     return inner;
> >                 }
> > 
> > In the current implementation, searching for the uid of a VEVENT will return the VCALENDAR component instead of the VEVENT.  Or is this intentional?
> > 
> I'll take a look.
> I don't know that anyone has been actively mucking around in icalfileset for many years
> so most likey not-intentional.
> 
> If you happen to have some test code we could use to verify and add to our test suite
> I would be happy to have it.
> 
> -Allen
> 
> 
>