[Freeassociation-devel] Revision 985 breaks Linux applications

[dothebart]

Oh man!  

i've been searching for those damn crashes on my devbox for quiet a while
now,  

thanks a lot for finding!  

   
>  Di Feb 16 2010 12:13:56 EST von  "Milan Crha" <mcrha at redhat.com>  Betreff:
>[Freeassociation-devel] Revision 985 breaks Linux applications
>
>  Hi all,
> after a really painful investigation of bug [1] the reporter finally
> realized that all this is caused by libical and commit [2], as he's
> using your trunk.
> 
> The problem is that there is defined vsnprintf function on most Linuxes
> (if not all), within glibc library [3], and it's a correct
> implementation. From the commit comments I understand you've it defined
> only for windows, and the file content should not be used anywhere else.
> If I'm correct, then the first line shouldn't be
>  
>>#ifndef WIN32
>>

>  but
>  
>>#ifdef WIN32
>>

>  instead. See how much one 'n' can do. The problem was that applications
> using libical are then not using the system vsnprintf, neither
> dynamically linked libraries in the application, but they are using that
> yours, which makes things behave unexpectedly.
> 
> I would like to ask you for two things:
> a) Please fix this as soon as possible.
> b) Please rename the .c file to something else, so it'll be obvious that
> it's not the system library, but that yours (debugger is showing only
> the .c file without path, by default.)
> 
> Thank you in advance and for your understandings.
> Bye,
> Milan
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=605811
> [2]
>
>http://freeassociation.svn.sourceforge.net/viewvc/freeassociation/trunk/libica
>l/src/libical/vsnprintf.c?r1=772&r2=985
> [3] http://sources.redhat.com/glibc/
> 
> 
>
>------------------------------------------------------------------------------
>
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel
> 
>
>
>  

  

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20100216/f4dcf510/attachment.html>