[Freeassociation-devel] Default value for ical_errors_are_fatal

[Chenthill]

On Wed, 2008-12-17 at 09:07 +0100, Patrick Ohly wrote:
> On Wed, 2008-12-17 at 05:01 +0530, Chenthill wrote:
> >    Till now all the applications which link to libecal use both libecal
> > (ECalComponent) and libical api's interchangeably as libecal does not
> > wrap all the functionality. Libical inside GNOME can only be built
> > inside EDS and so there can be a possibility that applications may link
> > to libecal and just use libical apis. In which case setting the variable
> > to 0 inside libecal may not suffice as we would now dynamically link to
> > libical.
> 
> So your concern is about applications which *are changed* by the
> developer to use upstream libical directly? Because applications which
> are *not* changed will still link against libecal. That was the only way
> how GNOME applications could get libical, because it wasn't a
> stand-alone library.
yes.

> 
> A developer who changes to upstream libical should be warned about the
> different default and then can choose to either disable fatal errors or
> fix his code, but I don't see this as a reason to change the default
> upstream.
I was thinking if could be made at-least a configurable option.

> 
> >  So this means we would need to set this option inside libecal
> > and also in external applications which uses libecal. 
>                                                ^^^^^^^
>                                    I assume you mean libical here.
yes.

> 
> My assumption is that there are no such GNOME applications. KDE apps
> seem to be fine with fatal errors. That leaves apps which have always
> used upstream libical - has the setting changed for them? If not, then I
> don't see a problem.

I did not want to assume it :) 

> 
> >    For the above reason, we were thinking if it can be set inside
> > libical through a configurable option it would be better. After fixing
> > the issues in packages which link to libecal, we will be happy to have
> > this option enabled. At the moment considering the effort available, we
> > may not be able to fix all the issues soon.
> 
> You don't have to. Just disable it in libecal and those developers who
> don't have time to adapt won't notice any difference.

I do not want to hold the upstream merge due to this. Probably we would
set fatal_errors in evolution, evolution-* packages and libecal.
Announce the change in e-h list and pgo asap. If anyone is affected they
would have enough time to set fatal_errors to 0. Since its not a very
huge change, if there are any apps, they can make this changes fast
enough. 


thanks, Chenthill.