[PATCH] libertas: convert GET_LOG to a direct command

Holger Schurig hs4233 at mail.mn-solutions.de
Thu Mar 13 04:48:36 EDT 2008


Now uses __lbs_cmd() to get the "log" (it's actually more a
snapshot of various counters, not a sequential log).

Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>

----

While looking here, I saw that that there is an imbalance on
populating priv->logmsg (via lbs_get_log() and it's usage.

lbs_get_log() is called twice:

* in assoc.c after a successful association
* in wext.c, lbs_get_wireless_stats()

however, priv->logmsg is only used once:

* in wext.c, lbs_get_wireless_stats(), to populate
  priv->wstats.discard.*

However, the usage in wext.c happens BEFORE the call to 
lbs_get_log(), so lbs_get_wireless_stats() actually works with 
old data. This seems strange ...

Does anybody know if this was intended behavior?  If not, I'd 
kill the calls to lbs_get_log() in assoc.c and move the other 
one to line 882 of wext.c.



More information about the libertas-dev mailing list