[RFC] [NET] libertas: fix ethtool -S

Dan Williams dcbw at redhat.com
Thu Mar 6 08:57:21 EST 2008

On Thu, 2008-03-06 at 10:33 +0100, Sebastian Siewior wrote:
> * Dan Williams | 2008-03-05 13:13:19 [-0500]:
> >Anything having to do with mesh should probably be protected by if
> >(priv->mesh_dev) or whatever it is.  If there's no mesh-enabled
> >firmware, there's no way this call can possibly work :)
> Argh, so this would explain why it doesn't work.
> What do you recommend besides grabbing the lock:
> - memset that memory area in error case.
> - check if mesh is supported by the firmware and if it not, return
>   -ENOSUPP in lbs_ethtool_get_sset_count()

The last one would be best, I think.  -ENOSUPP if no mesh.


More information about the libertas-dev mailing list