[RFC] [NET] libertas: fix ethtool -S

Sebastian Siewior bigeasy at tglx.de
Thu Mar 6 04:33:06 EST 2008

* Dan Williams | 2008-03-05 13:13:19 [-0500]:

>Anything having to do with mesh should probably be protected by if
>(priv->mesh_dev) or whatever it is.  If there's no mesh-enabled
>firmware, there's no way this call can possibly work :)
Argh, so this would explain why it doesn't work.
What do you recommend besides grabbing the lock:
- memset that memory area in error case.
- check if mesh is supported by the firmware and if it not, return
  -ENOSUPP in lbs_ethtool_get_sset_count()

Firmensitz: 88690 Uhldingen, Auf dem Berg 3
Registergericht: Amtsgericht Freiburg i. Br., HRB 700 806; StNr. 87007/07777; Ust-Id Nr.: DE252739476
Geschaeftsfuehrer: Heinz Egger, Thomas Gleixner

More information about the libertas-dev mailing list