[LEDE-DEV] [PATCH 3/3] lantiq: add device tree binding for dwc2 on danube

[Christian Lamparter]

Hello,

On Friday, October 28, 2016 4:30:56 PM CEST Ben Mulvihill wrote:
> Add device tree binding for dwc2 usb driver on lantiq danube
> 
> Signed-off-by: Ben Mulvihill <ben.mulvihill at gmail.com>
> ---
> diff -uprN a/target/linux/lantiq/dts/danube.dtsi b/target/linux/lantiq/dts/danube.dtsi
> --- a/target/linux/lantiq/dts/danube.dtsi	2016-10-27 19:56:07.090392399 +0200
> +++ b/target/linux/lantiq/dts/danube.dtsi	2016-10-27 20:47:34.387511522 +0200
> @@ -140,7 +140,7 @@
>  		};
>  
>  		ifxhcd at E101000 {
> -			compatible = "lantiq,ifxhcd-danube";
> +			compatible = "lantiq,ifxhcd-danube", "lantiq,ifxhcd-danube-dwc2";
Usually for device tree, the first compatible string is reserved for the
"exact device" that the node represents [0]. So wouldn't switching around
the strings (i.e.: "lantiq,ifxhcd-danube-dwc2", "lantiq,ifxhcd-danube")
make more sense? After all, the dwc2 is the "more exact device" in this case?

>  			reg = <0xE101000 0x1000
>  				0xE120000 0x3f000>;
>  			interrupt-parent = <&icu0>;
> 

[0] <http://elinux.org/Device_Tree_Usage#Understanding_the_compatible_Property>