[PATCH v2] supplicant: Fix MLD related IE parsing.

[Ben Greear]

On 11/7/23 09:57, Jouni Malinen wrote:
> On Sat, Oct 28, 2023 at 04:24:35PM -0700, greearb at candelatech.com wrote:
>> Now supplicant can deal with beacons containing multiple TBTT
>> elements.  This lets MLO connections be attempted against TPLINK
>> be800 AP.
>>
>> This also includes a good bit of logging changes, including
>> conversion to wpa_dbg so that wlan name is seen in the logs.
> 
> Thanks, applied with cleanup and quite a bit different design with the
> RNR iteration and TBTT Information iteration cases refactored to use
> helper functions to make the code readable. I split this into quite a
> bit larger number of changes since these are really independent changes.

Thanks for that, I'll rebase soon and give it a try.

> 
>> +					struct wpa_bss *neigh_bss =
>> +						wpa_bss_get_bssid(wpa_s, bssid);
>> +					u8 link_id = *(data + 1) & 0xF;
>> +
>> +					/* Intel radios won't scan 6e at first.  Would need to force
>> +					 * the radio to scan multiple times to fix that limitations.
>> +					 */
>> +					if (neigh_bss) {
>> +						u8 bss_params = *(data + (1 + 6 + 4 - 13));
>> +						if (((bss_params & 0x2) /* same ssid */
>> +						     && (bss_params & (1<<6))) || /* co-located AP */
>> +						    wpa_scan_res_match(wpa_s, 0, neigh_bss,
>> +								       wpa_s->current_ssid,
>> +								       1, 0)) {
> 
> I'm not sure what that comment about Intel radios is all about and how
> it is relevant to this patch, so I did not include it.

What I saw is that with this API, 6Ghz links could not be established because only 2.4/5ghz will
be scanned first (and then STA tries to associate before it finds the 6Ghz link).

I noticed in one of the other patches you applied, it appears that some Intel engineer had another API
that seemed an attempt to mitigate this.

And on our side, we can hack supplicant to wait until 6Ghz is scanned before it attempts MLO
connection if needed.

You don't need to add in the comment, google can find this email next time someone is curious :)

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com