[PATCH v2] supplicant: Fix MLD related IE parsing.

Jouni Malinen j at w1.fi
Tue Nov 7 09:57:52 PST 2023


On Sat, Oct 28, 2023 at 04:24:35PM -0700, greearb at candelatech.com wrote:
> Now supplicant can deal with beacons containing multiple TBTT
> elements.  This lets MLO connections be attempted against TPLINK
> be800 AP.
> 
> This also includes a good bit of logging changes, including
> conversion to wpa_dbg so that wlan name is seen in the logs.

Thanks, applied with cleanup and quite a bit different design with the
RNR iteration and TBTT Information iteration cases refactored to use
helper functions to make the code readable. I split this into quite a
bit larger number of changes since these are really independent changes.

> +					struct wpa_bss *neigh_bss =
> +						wpa_bss_get_bssid(wpa_s, bssid);
> +					u8 link_id = *(data + 1) & 0xF;
> +
> +					/* Intel radios won't scan 6e at first.  Would need to force
> +					 * the radio to scan multiple times to fix that limitations.
> +					 */
> +					if (neigh_bss) {
> +						u8 bss_params = *(data + (1 + 6 + 4 - 13));
> +						if (((bss_params & 0x2) /* same ssid */
> +						     && (bss_params & (1<<6))) || /* co-located AP */
> +						    wpa_scan_res_match(wpa_s, 0, neigh_bss,
> +								       wpa_s->current_ssid,
> +								       1, 0)) {

I'm not sure what that comment about Intel radios is all about and how
it is relevant to this patch, so I did not include it.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list