[PATCH 7/8] mka: remove "channel" hacks from the stack and the macsec_qca driver

Jouni Malinen j at w1.fi
Mon Oct 3 03:34:37 PDT 2016

On Tue, Sep 20, 2016 at 09:43:10AM +0200, Sabrina Dubroca wrote:
> This is specific to the macsec_qca driver. The core implementation
> shouldn't care about this, and only deal with the complete secure
> channel, and pass this down to the driver.
> Drivers that have such limitations should take care of these in their
> ->create functions and throw an error.
> Since the core MKA no longer saves the channel number, the macsec_qca
> driver must be able to recover it.  Add a map (which is just an array
> since it's quite short) to match SCIs to channel numbers, and lookup
> functions that will be called in every place where functions would get
> the channel from the core code.  Getting an available channel should be
> part of channel creation, instead of being a preparation step.

This does not apply with some of the earlier patches in the series
removed, so please resubmit this one based on updated versions of the
earlier patches that I had to drop.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list