[RFC 4/4] tests: Modify test_hs20_filter

Johannes Berg johannes at sipsolutions.net
Tue Mar 8 01:37:50 PST 2016


On Tue, 2016-03-08 at 11:02 +0200, Jouni Malinen wrote:
> On Tue, Mar 08, 2016 at 08:47:53AM +0100, Johannes Berg wrote:
> > On Mon, 2016-03-07 at 18:55 +0200, Ilan Peer wrote:
> > > Modify the test cases to tests the HS20 filtering functionality
> > > in wpa_supplicant, instead of testing only the kernel interface.
> > 
> > I wonder if we should keep both? But I guess it's wpa_supplicant
> > tests,
> > not kernel tests :)
> 
> I'm fine with including test cases that are mainly targeting
> cfg80211/mac80211 or related functionality, so if the previous test
> cases had additional coverage that would not be verified when going
> through wpa_supplicant to set the parameters, it would make sense to
> add new test cases instead of replace the existing ones.

Fair enough, but then it probably doesn't really make a difference.

johannes



More information about the Hostap mailing list