[PATCH 18/19] P2PS: add a wildcard with other advertised service info

Jouni Malinen j
Thu Jun 18 10:02:26 PDT 2015

On Thu, Jun 18, 2015 at 12:24:36PM +0000, Stepanov, Max wrote:
> Right, it's not a real "wildcard" hash. I used the same name to be comply the existing code convention.
> I agree that it makes sense change the variables names and add better comments with an additional patch.

I pushed in number of fixes to this behavior and some cleanup as well. I
think the current behavior matches the P2PS specification. Anyway,
additional review of those changes is obviously welcome.

P2PS: Fix P2P_FIND seek parameter parsing
P2PS: Verify service name length in P2P_FIND command
P2PS: Fix p2p_find handling to allow "wildcard" with other hash values
P2PS: Fix service hash matching for org.wi-fi.wfds
P2PS: Do not ignore other hashes if org.wi-fi.wfds hash is included
P2PS: Remove unnecessary service hash filtering from p2p_reply_probe()
P2PS: Add more debug prints for service info building
P2PS: Fix org.wi-fi.wfds matching when building the response
P2PS: Fix Probe Response frame building in error cases
tests: Extend P2PS service seek test to cover multiple services
tests: P2PS with large number of services in Probe Request/Response

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list