[PATCH 18/19] P2PS: add a wildcard with other advertised service info

Stepanov, Max Max.Stepanov
Thu Jun 18 05:24:36 PDT 2015

>-----Original Message-----
>From: Jouni Malinen [mailto:j at w1.fi]
>Sent: Thursday, June 18, 2015 14:54
>On Thu, Jun 18, 2015 at 02:01:08PM +0300, Jouni Malinen wrote:
>> On Wed, Jun 10, 2015 at 11:43:48AM +0300, Ilan Peer wrote:
>> > Quoting WFDS spec: "If multiple Service Hash values are included in
>> > the Probe Request frame the ASP shall find a match for each Service
>> > Hash, and it shall send a Probe Response frame with the information
>> > listed for all matched Service Hashes." This patch changes a
>> > handling of a wildcard hash matching by adding a wildcard
>> > 'org.wi-fi.wfds' info together with other hash matches.
>> Could you please clarify what kind of use case would use both the
>> wildcard hash and a specific hash in a single request? How is that
>> different from including just the wildcard hash? Would it be better to
>> provide all services (if there is enough room in the frame) as a
>> response if wildcard hash is included in the request?
>Actually, never mind this. There has clearly been some confusion in this area
>related to "wildcard hash" (which does not really seem to be a wildcard, but
>something quite different and this really needs to be renamed and
>commented better). It looks like it will be simplest to apply these patches first
>and then fix the remaining issues separately.

Right, it's not a real "wildcard" hash. I used the same name to be comply the existing code convention.
I agree that it makes sense change the variables names and add better comments with an additional patch.


More information about the Hostap mailing list