[PATCH 18/19] P2PS: add a wildcard with other advertised service info

Jouni Malinen j
Fri Aug 14 14:14:41 PDT 2015

On Sun, Jun 28, 2015 at 12:12:35AM +0300, Jouni Malinen wrote:
> On Tue, Jun 23, 2015 at 02:46:31PM +0000, Stepanov, Max wrote:
> > >P2PS: Fix service hash matching for org.wi-fi.wfds
> > >P2PS: Fix org.wi-fi.wfds matching when building the response
> > 
> > IMHO, these two patches are tricky. I tend to think that the original implementation was correct.
> > In P2PS 1.1 spec section 3.4.1: 
> > "The ASP?at the?Service Advertiser shall respond positively if a Service Seeker sends the hash value for ?org.wi-fi.wfds? and has at least one?advertised?P2Ps?service."
> These patches were based on this note in
> 'If the ASP finds a match with the Service Hash value of
> "org.wi-fi.wfds" (i.e. advertises one of the Wi-Fi Alliance defined
> services listed in 3.2), then in the Probe Response it shall set the
> value of its Service Name field to "org.wi-fi.wfds".'
> The bullet item that you are referring from 3.4.1 is also starting with
> "If any one of Wi-Fi Alliance defined services..". While that is a
> separate sentence just before the one you quoted above, I would be
> tempted to interpret the "P2Ps service" in that second sentence to be
> constrained by the "Wi-Fi Alliance defined".

I got confirmation on this interpretation being correct, so I'm planning
on leaving this commits in as-is for org.wi-fi.wfds matching.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list