Can we remove the eloop exception listener?

Ben Greear greearb
Mon Jun 25 12:23:08 PDT 2012


On 06/24/2012 03:15 AM, Jouni Malinen wrote:
> On Fri, Mar 30, 2012 at 02:24:43PM -0700, Ben Greear wrote:
>> It seems like the exception listener could be removed.  The only
>> user is dbus, and probably it can just use reader/writer (and
>> catch the exceptions when reading)???
>
> I don't think there was any response to this and I don't know the D-Bus
> code well enough to be able to easily comment on its needs. Did you have
> any particular reason for removing that option from eloop? If you can
> provide a patch that removes this and maintains the D-Bus interface
> functionality, this could be considered.

I wanted to remove it mainly because it cannot be properly
implemented when using poll() because you can't poll just
for exceptions.

And, if we can remove it, it makes the eloop code smaller
and simpler.

My plan would be to just fail the debus request to add
an exception handler and hope that their code can deal
with that properly (if indeed they use that interface
at all).

But, I don't have any way of testing this, so perhaps
it is not worth the effort?

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com




More information about the Hostap mailing list