[PATCH 1/2] p2p: disable 11b rates only on p2p interface creation

Jouni Malinen j
Sat Sep 10 12:09:12 PDT 2011

On Sun, Sep 04, 2011 at 07:41:32PM +0200, Johannes Berg wrote:
> On Sat, 2011-09-03 at 22:21 +0530, Rajkumar Manoharan wrote:
> > 11b rates are disabled blindly during p2p init based on driver
> > capability. This prevents use of CCK rates where p2p is not in
> > use. This patch disables 11b rates during the p2p interface
> > setup and also removes the disable_11b from global.
> This looks OK to me, but I have no idea if it breaks anything for other,
> non-open-source, driver wrappers... :-)

Well, it does break compilation (trivial to fix), but driver_nl80211.c
is actually the only driver wrapper that I've heard of using this. Many
drivers handle P2P TX rate rules internally without any configuration

> Also I guess there will be a philosophical question as to whether or not
> the 11b disabling should be implicit (in driver_nl80211.c) or explicit
> (as it was before).

I think I'm fine with making this implicit for the default rule and
assume that driver wrappers handle that based on what the driver needs
(or doesn't, as may be the case). It can still be explicit in some
operations like scan.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list