#defines for the Command strings

[Jouni Malinen]

On Fri, Sep 01, 2006 at 07:53:32AM -0700, George S. Lockwood wrote:

> Along the lines of the new #define WPA_SUPPLICANT_NAMED_PIPE which
> could be defined in a common header such as build_config.h -GREAT,  I
> believe it also a good idea to #define the command strings (e.g.
> "ADD_NETWORK" & "LIST_NETWORKS", et al.) in that or a new header file.
> 
> like:
> 
> #define ADD_NETWORK  "ADD_NETWORK"
> 
> then replace the references to "ADD_NETWORK" with ADD_NETWORK.

If this was done to remove constants from the code, that could be
possible. However..

> this is for security purposes.

If this is done to change those values with this claim, I do not plan on
doing it. I'm not a huge fan of security by obscurity. If you believe
there is a security problem here, please describe the problem and let's
try to get a reasonable solution for it. Just replacing the command
strings does not provide security.

-- 
Jouni Malinen                                            PGP id EFC895FA