Your message to get_iplayer awaits moderator approval

[dinkypumpkin]

On 09/11/2014 15:52, C E Macfarlane wrote:
>
>>      The part of the program finding external programs has had to
>>      be rewritten to use nice.
>
> Even without nice, I think this aspect of it would be worth incorporating
> into get_iplayer, because, at the moment, the various tests for external
> program existence and versions are scattered throughout the code.  My patch

The tests are scattered for a reason.  No need to check binaries if they 
aren't going to be used.  That's less relevant in get_iplayer than it 
once was, but still applies.

> at least searches for all the external binaries up front  -  I think for the
> future it would be a good idea to test for the versions there as well  -
> and sets the bin->{name} variable either to the path to each, or to a null

That way lies madness.  Parsing the multitudes of version strings 
get_iplayer might encounter would be pointless.  In general, there is no 
reason for such tight coupling - get_iplayer doesn't do anything 
specialised with the external applications.