[PATCH] USB: host: hub: increase delay after device removal

Sascha Hauer s.hauer at pengutronix.de
Mon Jan 9 00:38:55 PST 2017


Hi Christoph,

On Wed, Dec 28, 2016 at 04:29:44PM +0100, Christoph Fritz wrote:
> This patch increases delay time for slow hubs after device removal.

Could you spent a few words what happens without this patch, i.e. how
the symptons look and which hardware you observed that? Without this
information it will be very hard to ever change this line again.

Sascha

> 
> Signed-off-by: Christoph Fritz <chf.fritz at googlemail.com>
> ---
>  drivers/usb/core/hub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index f44aea5..0854e3a 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -201,7 +201,7 @@ static void usb_hub_port_connect_change(struct usb_device *dev, int port)
>  	if (dev->children[port] && !(portstatus & USB_PORT_STAT_ENABLE))
>  		usb_remove_device(dev->children[port]);
>  
> -	mdelay(200);
> +	mdelay(500);
>  
>  	/* Reset the port */
>  	if (hub_port_reset(dev, port, &portstatus) < 0) {
> -- 
> 2.1.4
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list