[PATCH] serial: imx: Fix buggy transmissions when baudrate mismatches

Fabio Estevam festevam at gmail.com
Wed May 28 12:57:18 PDT 2014


On Thu, May 15, 2014 at 7:05 PM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Sascha,
>
> On Thu, May 15, 2014 at 6:21 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
>
>>> --- a/drivers/serial/serial_imx.c
>>> +++ b/drivers/serial/serial_imx.c
>>> @@ -258,7 +258,8 @@ static int imx_serial_getc(struct console_device *cdev)
>>>         while (readl(priv->regs + priv->devtype->uts) & UTS_RXEMPTY);
>>>
>>>         ch = readl(priv->regs + URXD0);
>>> -
>>> +       if (ch >= 0x80)
>>> +               ch = '?';
>>
>> This is not part of the fix, right?
>
> Correct, this is not part of the fix.
>
> This code is just to help reproducing the issue in console, without
> the need of hooking an oscilloscope to the UART pins or inspecting
> directly the UART TX registers.

Any comments, Sascha?

The same fix has also been applied to the kernel:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=b38cb7d2571197b56cefae8967f9db15c9361113



More information about the barebox mailing list