[RFC] [WIP] incorporate picotcp into barebox: a small demo

Sascha Hauer s.hauer at pengutronix.de
Tue May 27 23:08:59 PDT 2014


On Tue, May 27, 2014 at 06:04:11PM +0400, Antony Pavlov wrote:
> On Tue, 27 May 2014 11:46:29 +0200
> Daniele Lacamera <daniele.lacamera at tass.be> wrote:
> 
> $ gcc --version
> gcc (Debian 4.8.3-1) 4.8.3
> 
> Here is my 'make -s' output for sandbox barebox:
> 
> net/picotcp/modules/pico_ipv4.c: In function ‘pico_ipv4_rebound_large’:
> net/picotcp/modules/pico_ipv4.c:1582:24: warning: unused variable ‘fr’ [-Wunused-variable]
>      struct pico_frame *fr;
>                         ^
> net/picotcp/modules/pico_ipv4.c:1581:14: warning: unused variable ‘len’ [-Wunused-variable]
>      uint32_t len = f->transport_len;
>               ^
> net/picotcp/modules/pico_ipv4.c:1580:14: warning: unused variable ‘total_payload_written’ [-Wunused-variable]
>      uint32_t total_payload_written = 0;
>               ^

That's another advantage of IS_ENABLED. This happens because the variables are
only used under an ifdef. Fixing this would mean to put the definitions under
the same ifdef which requires another ifdef.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list