[PATCH 3/4] ARM: omap: barebox update nand xloadslots handler

[Sascha Hauer]

Hi Wadim,

On Mon, May 12, 2014 at 02:24:21PM +0200, Wadim Egorov wrote:
> +/*
> + * Register an am33xx xload slots update handler
> + */
> +int am33xx_bbu_nand_xloadslots_register_handler(const char *name,
> +						char *devicefile)

You should use char **devicefile, int num_devicefiles to pass the files.
This makes your code simpler and more obvious.

> +{
> +	struct bbu_handler *handler;

You'll need a struct nand_bbu_handler in which you embed struct
bbu_handler to make that work.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |