[PATCH v9 4/5] wifi: ath12k: Fill pdev id for fw test cmd
Aditya Kumar Singh
quic_adisi at quicinc.com
Tue Jan 14 21:26:25 PST 2025
On 1/15/25 09:55, Aaradhana Sahu wrote:
> Currently pdev id is not set properly. That can cause a crash
> if pdev id is not equal to the pdev id when firmware test
> command is run during AP bring up or ping.
>
> Set pdev id in function ath12k_tm_cmd_wmi to resolve this
> issue.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Co-developed-by: Rajat Soni <quic_rajson at quicinc.com>
> Signed-off-by: Rajat Soni <quic_rajson at quicinc.com>
> Signed-off-by: Aaradhana Sahu <quic_aarasahu at quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/testmode.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
Previous patch "[PATCH v9 3/5] wifi: ath12k: add factory test mode
support" only added testmode.c file isn't it? So can't we squash this
patch in that?
Let's not introduce a bug in patch X and then in same series fix it at
patch Y.
--
Aditya
More information about the ath12k
mailing list