[PATCH v9 4/5] wifi: ath12k: Fill pdev id for fw test cmd
Aaradhana Sahu
quic_aarasahu at quicinc.com
Tue Jan 14 20:25:31 PST 2025
Currently pdev id is not set properly. That can cause a crash
if pdev id is not equal to the pdev id when firmware test
command is run during AP bring up or ping.
Set pdev id in function ath12k_tm_cmd_wmi to resolve this
issue.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Co-developed-by: Rajat Soni <quic_rajson at quicinc.com>
Signed-off-by: Rajat Soni <quic_rajson at quicinc.com>
Signed-off-by: Aaradhana Sahu <quic_aarasahu at quicinc.com>
---
drivers/net/wireless/ath/ath12k/testmode.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/testmode.c b/drivers/net/wireless/ath/ath12k/testmode.c
index ac9ffa765ef6..18d56a976dc7 100644
--- a/drivers/net/wireless/ath/ath12k/testmode.c
+++ b/drivers/net/wireless/ath/ath12k/testmode.c
@@ -301,9 +301,10 @@ static int ath12k_tm_cmd_wmi(struct ath12k *ar, struct nlattr *tb[])
{
struct ath12k_wmi_pdev *wmi = ar->wmi;
struct sk_buff *skb;
- u32 cmd_id, buf_len;
- int ret = 0;
+ struct wmi_pdev_set_param_cmd *cmd;
+ int ret = 0, tag;
void *buf;
+ u32 cmd_id, buf_len;
if (!tb[ATH_TM_ATTR_DATA])
return -EINVAL;
@@ -321,6 +322,12 @@ static int ath12k_tm_cmd_wmi(struct ath12k *ar, struct nlattr *tb[])
cmd_id = nla_get_u32(tb[ATH_TM_ATTR_WMI_CMDID]);
+ cmd = buf;
+ tag = le32_get_bits(cmd->tlv_header, WMI_TLV_TAG);
+
+ if (tag == WMI_TAG_PDEV_SET_PARAM_CMD)
+ cmd->pdev_id = cpu_to_le32(ar->pdev->pdev_id);
+
ath12k_dbg(ar->ab, ATH12K_DBG_TESTMODE,
"testmode cmd wmi cmd_id %d buf length %d\n",
cmd_id, buf_len);
--
2.34.1
More information about the ath12k
mailing list