ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs

Christian Lamparter chunkeey at gmail.com
Fri Jan 21 06:33:55 PST 2022


Hi Kalle,

On 21/01/2022 15:05, Kalle Valo wrote:
> Christian Lamparter <chunkeey at gmail.com> writes:
> 
>> this is a set of board.bin files for the ASRock G10,
>> which I wish to be added to the ath10k-firmware repository.
>>
>> As per the current "Submitting board files" guidelines [1]:
>>
>> * description for what hardware this is:
>>    - it is a IPQ8064 based board with
>>      - one QCA9980 radio is used as 2.4 GHz radio
>>      - one QCA9980 radio is used as 5 GHz radio
>>
>> * origin of the board file (did you create it yourself or where you downloaded
>>    all files were extracted from official vendor firmware which was on the device.
>>
>> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>>    - qca9980 hw2.0
>>      + bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>>      + bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
>> * md5sum of each new board file to add
>>
>> ae069744baeebfd6861e8080a92439ca  bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>> 9e196846841a186e61ea208cc873384c  bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
> 
> There is no QCA9880 directory in ath10k-firmware, do you mean this
> should be added to QCA988X/hw2.0/board-2.bin?

It's a 9980 chip. This was 9984 predecessor.
         ^ = Watch out for that 9! <https://www.qualcomm.com/products/qca9980>

It would belong to the 99X0 directory of your ath10k-firmware repo:
https://github.com/kvalo/ath10k-firmware/tree/master/QCA99X0/hw2.0

But there's one issue: there is no v2 board-2.bin in there yet.

However the codeaurora's ath10k-firmware repo provides the board-2.bin here:
https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0/board-2.bin

(this also includes the reference bmi-board-id for 2, 4 and 6. I guess this
would help other people as well):
https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0

So could you please add that board-2.bin from codeaurora and add
the ASRock G10 specific variant to it? That would be sweet.

Thank you,
Christian



More information about the ath10k mailing list