[PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size

Wen Gong wgong at codeaurora.org
Mon Mar 8 07:22:23 GMT 2021


On 2021-02-11 00:53, Steven Rostedt wrote:
> On Wed, 10 Feb 2021 11:48:23 -0500
> Steven Rostedt <rostedt at goodmis.org> wrote:
> 
>> On Wed, 10 Feb 2021 11:30:26 -0500
>> Steven Rostedt <rostedt at goodmis.org> wrote:
>> 
>> > Can you test this patch?
>> 
>> v2:
> 
> Bah!
> 
> v3:
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index b79bcacdd6f9..90d7ade03499 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2739,7 +2739,7 @@ trace_event_buffer_lock_reserve(struct
> trace_buffer **current_rb,
>  	    (entry = this_cpu_read(trace_buffered_event))) {
>  		/* Try to use the per cpu buffer first */
>  		val = this_cpu_inc_return(trace_buffered_event_cnt);
> -		if (val == 1) {
> +		if ((len < (PAGE_SIZE - sizeof(*entry))) && val == 1) {
>  			trace_event_setup(entry, type, trace_ctx);
>  			entry->array[0] = len;
>  			return entry;
After apply this 
patch(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/trace/trace.c?id=b220c049d5196dd94d992dd2dc8cba1a5e6123bf).
It not crash again on my v4.19 kernel.



More information about the ath10k mailing list