[PATCH] ath10k: fix the status check and wrong return

Steve deRosier derosier at gmail.com
Tue Aug 18 00:40:42 EDT 2020

On Mon, Aug 17, 2020 at 6:43 PM Tang Bin <tangbin at cmss.chinamobile.com> wrote:
> Hi Kalle:
> 在 2020/8/17 22:26, Kalle Valo 写道:
> >> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
> >> return NULL. Thus use IS_ERR() and PTR_ERR() to validate
> >> the returned value instead of IS_ERR_OR_NULL().
> > Why? What's the benefit of this patch? Or what harm does
> > IS_ERR_OR_NULL() create?
> Thanks for you reply, the benefit of this patch is simplify the code,
> because in
> this function, I don't think the situation of 'devm_clk_get() return
> NULL' exists.

I admit I'm not looking at HEAD, but at least in the two versions I've
got checked out, devm_clk_get() can theoretically return NULL. This
feels like a gratuitous change anyway, but in any case it's wrong and
could cause wrong behavior.

- Steve

More information about the ath10k mailing list