Question on "ath10k: document ofdm/5ghz rate offset with a macro"

Ben Greear greearb at
Tue Jun 7 05:57:32 PDT 2016

On 06/06/2016 11:23 PM, Michal Kazior wrote:
> On 6 June 2016 at 23:25, Ben Greear <greearb at> wrote:
>> While porting some patches forward, I notice the change below
>> that renamed the method to "ath10k_mac_sta_has_ofdm_only".  But,
>> that is not really what that is checking, since it just throws
>> away the CCK rates (and they might have been there).
>> Maybe it should just be "ath10k_mac_sta_has_ofdm()" ?
> Yes, this seems like an unfortunate name pick on my side. The MODE_11G
> phymode is for mixed b/g.

I think the actual code behaviour is right.  I have some patches to
support G-only mode and such, and will change the name of your method
in those patches to be more clear.

Lots of other pending patches of mine before I will get to trying to push
that one upstream though.


Ben Greear <greearb at>
Candela Technologies Inc

More information about the ath10k mailing list