[PATCH 2/3] ath10k: always save/restore pci config space

Michal Kazior michal.kazior at tieto.com
Mon Mar 2 01:23:53 PST 2015


On 2 March 2015 at 10:16, Johannes Berg <johannes at sipsolutions.net> wrote:
> On Mon, 2015-03-02 at 10:09 +0100, Michal Kazior wrote:
>> The check isn't really necessary and couldn't even
>> work because becase pci_restore_state() restores
>> only first 64 bytes of PCI configuration space.
>>
>> This is necessary for future WoWLAN support.
>
>> +     pci_save_state(pdev);
>> +     pci_disable_device(pdev);
>
> I believe the whole thing isn't necessary at all since the kernel's PCIe
> layer will take care of it.

You mean only the pci_save_state() and pci_disable_device() or, the
resume counterpart as well? Hmm.

Earlier the resume counterpart didn't do any restore stuff and the
device ended up pretty confused..


Michał



More information about the ath10k mailing list