[PATCH] ath10k:Prevent setting wrong key idx for station

SenthilKumar Jegadeesan sjegadee at qti.qualcomm.com
Wed Jan 28 02:21:01 PST 2015


On Wed, Jan 28, 2015 at 03:22:07PM +0530, SenthilKumar Jegadeesan wrote:
> On Wed, Jan 28, 2015 at 10:23:35AM +0200, Kalle Valo wrote:
> > <senthilb at qti.qualcomm.com> writes:
> > 
> > > From: SenthilKumar Jegadeesan <sjegadee at qti.qualcomm.com>
> > >
> > > Ath10k driver sets wrong default key idx that results in
> > > sending unicast frames with multicast key.
> > >
> > > The reason for this behavior is that cached broadcast key
> > > is installed for station MAC address on association. After
> > > dot1x completes, unicast key is installed for station
> > > MAC address. Default key idx is set to broadcast key id when
> > > driver tries to send broadcast frame. This causes firmware
> > > to use broadcast key id to transmit unicast frames to stations.
> > >
> > > Used TX_USAGE flag to set default key for stations.
> > >
> > > Added callback for setting unicast default idx which will be
> > > invoked on every default key idx configuration.
> > >
> > > Signed-off-by: SenthilKumar Jegadeesan <sjegadee at qti.qualcomm.com>
> > 
> > I had a trivial conflict in ath10k_add_interface(), please double check
> > my conflict resolution in the pending branch:
> > 
> > https://github.com/kvalo/ath/commit/34e5197d250d7be04bba5ad2b2d33cd9a7c41b0f
> > 
> > And in the future please also CC linux-wireless when submitting ath10k
> > patches.
> >
> Kalle, 
> 
> Confilcts aren't resolved properly. I will re-send the patch from top of the
> branch. 
>
The conflicts are resolved correclty. Sorry for the confusion.

Thanks,
Senthil J




More information about the ath10k mailing list