[PATCH 3/3] ath10k: support 32+ stations.

Kalle Valo kvalo at qca.qualcomm.com
Tue Sep 23 05:59:06 PDT 2014


greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
>
> Support up to 32 stations when using CT firmware.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>

[...]

> -	if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
> +	if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features))
> +		ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS_CT) - 1;
> +	else if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
>  		ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS) - 1;
>  	else
>  		ar->free_vdev_map = (1LL << TARGET_NUM_VDEVS) - 1;

[...]

> +/* Over-rides for Candela Technologies firmware */
> +#define TARGET_10X_NUM_VDEVS_CT			32
> +#define TARGET_10X_NUM_PEERS_CT			(32 + (TARGET_10X_NUM_VDEVS_CT))
> +#define TARGET_10X_AST_SKID_LIMIT_CT		(TARGET_10X_NUM_PEERS_CT * TARGET_10X_NUM_PEER_AST)

[...]

> +		if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features))
> +			max_num_peers = TARGET_10X_NUM_PEERS_CT - 1;

Like I said before, this hardcoding of values using feature bits is not
going to work in the long run. It's better that these values come
directly from FW IEs as integers, that gives us a lot more flexibility
between firmware versions.

That's why I'll drop patches 2 and 3.

-- 
Kalle Valo



More information about the ath10k mailing list