[PATCH 1/3] ath10k: use 64-bit vdev map.

[Michal Kazior]

On 19 September 2014 20:04,  <greearb at candelatech.com> wrote:
> From: Ben Greear <greearb at candelatech.com>
>
> This can allow more than 32 stations to be supported
> without over-running the bitmap.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>
> ---
>  drivers/net/wireless/ath/ath10k/core.c |  4 ++--
>  drivers/net/wireless/ath/ath10k/core.h |  2 +-
>  drivers/net/wireless/ath/ath10k/mac.c  | 21 ++++++++++++---------
>  3 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index cee18c8..37e3166 100644
[...]
> @@ -2772,9 +2772,12 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
>                 ret = -EBUSY;
>                 goto err;
>         }
> -       bit = ffs(ar->free_vdev_map);
> +       bit = __ffs64(ar->free_vdev_map);
>
> -       arvif->vdev_id = bit - 1;
> +       ath10k_warn(ar, "Creating vdev id: %i  map: %llu\n",
> +                   bit, ar->free_vdev_map);

Shouldn't this be a ath10k_dbg()? It probably makes sense to print the
map as hex instead of a decimal too. Prints should be lower case and
debug needs a prefix, i.e.

 "mac create vdev %i map %llx"


Michał