[PATCH 2/3] ath10k: dump hex bytes with dev string prefix

[Michal Kazior]

On 22 September 2014 12:52, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>
>> This makes it easier to debug hex dumps on systems
>> with more than a single ath10k device.
>>
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
>
> [...]
>
>> -             print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len);
>> +             for (ptr = buf; (ptr - buf) < len; ptr += 16) {
>> +                     linebuflen = 0;
>> +                     if (prefix)
>> +                             linebuflen += scnprintf(linebuf + linebuflen,
>> +                                                     sizeof(linebuf) -
>> +                                                     linebuflen,
>> +                                                     "%s", prefix);
>> +                     linebuflen += scnprintf(linebuf + linebuflen,
>> +                                             sizeof(linebuf) - linebuflen,
>> +                                             "%08x: ",
>> +                                             (unsigned int)(ptr - buf));
>> +                     hex_dump_to_buffer(ptr, len - (ptr - buf), 16, 1,
>> +                                        linebuf + linebuflen,
>> +                                        sizeof(linebuf) - linebuflen, true);
>> +                     dev_printk(KERN_DEBUG, ar->dev, "%s\n", linebuf);
>> +             }
>
> Would it be possible to simplify this to one scnprintf()? Something
> like:
>
> linebuflen += scnprintf(linebuf + linebuflen,
>                         sizeof(linebuf) - linebuflen,
>                         "%s%08x: ",
>                         prefix ? prefix : "",
>                         (unsigned int)(ptr - buf));

It should be fine. You want me to re-send it?


Michał