[PATCH v4 2/2] ath10k: add testmode

[Michal Kazior]

On 10 September 2014 17:23, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
[...]

Just a small nitpick:

> +static int ath10k_tm_cmd_utf_stop(struct ath10k *ar, struct nlattr *tb[])
> +{
> +       int ret;
> +
> +       ath10k_dbg(ar, ATH10K_DBG_TESTMODE, "testmode cmd utf stop\n");
> +
> +       mutex_lock(&ar->conf_mutex);
> +
> +       if (ar->state != ATH10K_STATE_UTF) {
> +               ret = -ENETDOWN;
> +               goto out;
> +       }
> +
> +       __ath10k_tm_cmd_utf_stop(ar);
> +
> +       ar->state = ATH10K_STATE_OFF; // <-- this

I would move it to __ath10k_tm_cmd_utf_stop() itself so that the state
is reset in ath10k_testmode_destroy() as well.


Michał