[PATCH v5] ath10k: save firmware debug log messages.

Michal Kazior michal.kazior at tieto.com
Tue Sep 2 06:51:58 PDT 2014


On 2 September 2014 15:38, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> (Dropping linux-wireless)
>
> greearb at candelatech.com writes:
>
>> From: Ben Greear <greearb at candelatech.com>
>>
>> They may be dumped through the firmware dump debugfs
>> file.
>>
>> Signed-off-by: Ben Greear <greearb at candelatech.com>
>
> Before I start looking at this in detail: this looks fragile and
> complicated from ath10k point of view. Why not just take a dump of the
> whole firmware memory and postprocess this, with whatever else we might
> need from the firmware? That's a lot easier to maintain.

I like the idea although it still makes sense to keep some sort of a
circular buffer for the debug mesg events delivered via wmi, does it
not?


Michał



More information about the ath10k mailing list