[PATCH 1/2] ath10k: remove tsf argument from rx_desc tracing
Kalle Valo
kvalo at qca.qualcomm.com
Thu Oct 23 07:10:31 PDT 2014
Michal Kazior <michal.kazior at tieto.com> writes:
> On 21 October 2014 15:54, Michal Kazior <michal.kazior at tieto.com> wrote:
>> Fundamtenally this was wrong. Tsf is only valid
>> in first MPDU of a PPDU. This means tsf value was
>
> s/first MPDU/last MPDU/
>
> I must've had a brain fart when writing the commit log yesterday.
>
> @Kalle: Should I re-spin or will you fix it before applying?
No need to re-spin, I edited the commit log in ath-next-test. I also
fixed a typo in "fundamentally".
commit d75153c577ddfffa9e7438e8225dfaf564f34552
Author: Michal Kazior <michal.kazior at tieto.com>
Date: Thu Oct 23 17:04:27 2014 +0300
ath10k: remove tsf argument from rx_desc tracing
Fundamentally this was wrong. Tsf is only valid
in last MPDU of a PPDU. This means tsf value was
wrong most of the time during heavy traffic.
Also I don't see much point in exposing a
redundant (and broken) tsf value. Userspace can
already read it from the dumped rx descriptor
buffer.
Cc: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
--
Kalle Valo
More information about the ath10k
mailing list