[PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

Felix Fietkau nbd at openwrt.org
Thu Oct 23 03:57:15 PDT 2014


On 2014-10-23 09:13, Kalle Valo wrote:
> Felix Fietkau <nbd at openwrt.org> writes:
> 
>> Signed-off-by: Felix Fietkau <nbd at openwrt.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 4670930..bc440dc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>  
>>  	survey->channel = &sband->channels[idx];
>>  
>> +	if (ar->rx_channel == survey->channel)
>> +		survey->filled |= SURVEY_INFO_IN_USE;
>> +
> 
> Why? Does this fix a visible bug? What changes from user space point of
> view? I'm asking because I want to add something to the commit log.
When user space requests survey info, it is useful to know which of the
survey data refers to the channel that is currently actively being used.
One of the use cases is getting the current channel noise for status output.
Without this flag you would have to look up the channel separately and
then compare it against the frequency in the survey output in user space.

- Felix



More information about the ath10k mailing list