[PATCH 7/7] ath10k: implement wmi-tlv backend

[Ben Greear]

On 10/20/2014 05:58 AM, Michal Kazior wrote:
> Latest firmware revision introduced a new WMI ABI
> called wmi-tlv. It is not a tlv strictly speaking
> but something that resembles it because it is
> ordered and may have duplicate id entries.
> 
> This will be used by new hardware eventually.
> 

> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 00cff91..3fea38c 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -364,6 +364,9 @@ enum ath10k_fw_features {
>  	 */
>  	ATH10K_FW_FEATURE_WMI_10_2 = 4,
>  
> +	/* Firmware uses WMI TLV */
> +	ATH10K_FW_FEATURE_WMI_TLV = 5,
> +
>  	/* keep last */
>  	ATH10K_FW_FEATURE_COUNT,
>  };

It sucks for me that I cannot get a feature-flag for my firmware upstream,
so my kernels and firmware keep loosing compatibility each time you
add a new flag.

I guess I will just have to pick a much larger value and just hope it
won't collide for a while.

But, if you are at liberty to change this, please skip 5 and 6,
and make yours be 7 (my kernel/firmware currently uses the two below):

	/* Firmware from Candela Technologies, enables more VIFs, etc */
	ATH10K_FW_FEATURE_WMI_10X_CT = 5,

	/* Firmware from Candela Technologies with rx-software-crypt.
	 * Required for multiple stations connected to same AP when using
	 * encryption (ie, commercial version of CT firmware) */
	ATH10K_FW_FEATURE_CT_RXSWCRYPT = 6,


Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com