[PATCH 3/4] ath10k: Add more debugging for receive errors.
Kalle Valo
kvalo at qca.qualcomm.com
Wed Feb 5 03:16:18 EST 2014
Ben Greear <greearb at candelatech.com> writes:
>>> @@ -975,6 +976,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>>> info.skb = msdu_head;
>>> info.fcs_err = ath10k_htt_rx_has_fcs_err(msdu_head);
>>> info.mic_err = ath10k_htt_rx_has_mic_err(msdu_head);
>>> +
>>> + if (info.fcs_err)
>>> + ath10k_warn("htt rx has FCS err\n");
>>> +
>>> + if (info.mic_err)
>>> + ath10k_warn("htt rx has MIC err\n");
>>> +
>>
>> Do we really want to print warning messages to the user when these
>> happen? I would consider these as "business as usual" in 802.11 world,
>> not a problem in driver.
>
> Maybe I should make them a debug message instead of warning message? That
> way they are only shown if the user enables debugging?
Yeah, having them as debug messages makes sense.
--
Kalle Valo
More information about the ath10k
mailing list