[PATCH 4/4] ath10k: Better tx/rx debugging.

Kalle Valo kvalo at qca.qualcomm.com
Tue Feb 4 13:55:10 EST 2014


greearb at candelatech.com writes:

> From: Ben Greear <greearb at candelatech.com>
>
> Make it easier to grep for htt rx errors.
>
> Signed-off-by: Ben Greear <greearb at candelatech.com>

[...]

> @@ -961,6 +962,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>  			}
>  
>  			if (test_bit(ATH10K_CAC_RUNNING, &htt->ar->dev_flags)) {
> +				ath10k_warn("htt rx: CAC running\n");
>  				ath10k_htt_rx_free_msdu_chain(msdu_head);
>  				continue;
>  			}

I'm a bit worried about this one. Do we guarantee that we will never
receive frames while CAC is running? In other words, is this a normal
event or really an error in the driver which requires a warning message?

Janusz, what do you think?

-- 
Kalle Valo



More information about the ath10k mailing list