[PATCH 6/6] ath10k: move fw init print

Kalle Valo kvalo at qca.qualcomm.com
Tue Aug 12 00:53:04 PDT 2014


Michal Kazior <michal.kazior at tieto.com> writes:

> Firmware probing is done only once when driver is
> registered and firmware version is guaranteed to
> remain the same until driver is unregistered.
>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

[...]

> @@ -816,24 +816,6 @@ int ath10k_core_start(struct ath10k *ar)
>  
>  	INIT_LIST_HEAD(&ar->arvifs);
>  
> -	if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
> -		ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
> -			    ar->hw_params.name,
> -			    ar->target_version,
> -			    ar->chip_id,
> -			    ar->hw->wiphy->fw_version,
> -			    ar->fw_api,
> -			    ar->htt.target_version_major,
> -			    ar->htt.target_version_minor);
> -		ath10k_info("debug %d debugfs %d tracing %d dfs %d\n",
> -			    config_enabled(CONFIG_ATH10K_DEBUG),
> -			    config_enabled(CONFIG_ATH10K_DEBUGFS),
> -			    config_enabled(CONFIG_ATH10K_TRACING),
> -			    config_enabled(CONFIG_ATH10K_DFS_CERTIFIED));
> -	}
> -
> -	__set_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags);

Doesn't this break this print in pci.c:

        if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags))
           ath10k_info("pci irq %s irq_mode %d reset_mode %d\n",
                                    irq_mode, ath10k_pci_irq_mode,
                                                    ath10k_pci_reset_mode);

-- 
Kalle Valo



More information about the ath10k mailing list