[PATCH v5 6/7] ath10k: save firmware RAM and ROM BSS sections on crash

[Ben Greear]

On 08/08/2014 01:29 PM, Kalle Valo wrote:
>  
> +/* estimated values, hopefully these are enough */
> +#define ATH10K_ROM_BSS_BUF_LEN 10000
> +#define ATH10K_RAM_BSS_BUF_LEN 30000
> +
>  /* used for crash-dump storage, protected by data-lock */
>  struct ath10k_fw_crash_data {
>  	bool crashed_since_read;
> @@ -301,6 +305,9 @@ struct ath10k_fw_crash_data {
>  	u32 reg_dump_values[REG_DUMP_COUNT_QCA988X];
>  	u8 stack_buf[ATH10K_FW_STACK_SIZE];
>  	u8 exc_stack_buf[ATH10K_FW_STACK_SIZE];
> +
> +	u8 rom_bss_buf[ATH10K_ROM_BSS_BUF_LEN];
> +	u8 ram_bss_buf[ATH10K_RAM_BSS_BUF_LEN];
>  };

That (using estimates instead of allocating memory when we know
the true value and/or when we need it)
is wasting quite a bit of RAM.  Doesn't matter on my systems,
but AP manufacturers might be more ticklish about RAM usage...


> +	/* These are written to only during first firmware boot so no need
> +	 * for locking. */

It's 'firmware load' instead of boot maybe?


Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com