[PATCH v5 2/7] ath10k: provide firmware crash info via debugfs

[Ben Greear]

On 08/08/2014 01:28 PM, Kalle Valo wrote:

> +
> +	getnstimeofday(&timestamp);
> +	dump_data->tv_sec = timestamp.tv_sec;
> +	dump_data->tv_nsec = timestamp.tv_nsec;

I wonder if we should take timestamp at crash time instead of crash-dump-gather time?


>  int ath10k_debug_create(struct ath10k *ar)
>  {
> +	ar->debug.fw_crash_data = vzalloc(sizeof(ar->debug.fw_crash_data));
> +	if (!ar->debug.fw_crash_data)
> +		return -ENOMEM;
> +

That sizeof looks quite wrong.


Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com