[PATCH v5 1/5] wcn36xx: Add accessor macro HW_VALUE_CHANNEL for hardware channels

Kalle Valo kvalo at codeaurora.org
Tue Sep 22 03:29:02 EDT 2020


Kalle Valo <kvalo at codeaurora.org> writes:

> Bryan O'Donoghue <bryan.odonoghue at linaro.org> wrote:
>
>> Adds HW_VALUE_CHANNEL(hw_value) an access macro that will be used to
>> extract the channel number from struct ieee80211_channel->hw_value in
>> preparation for also storing PHY settings for 802.11ac in the upper bits of
>> hw_value.
>> 
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
>> Signed-off-by: Kalle Valo <kvalo at codeaurora.org>
>
> 5 patches applied to ath-next branch of ath.git, thanks.
>
> 59b5c8447c14 wcn36xx: Add accessor macro HW_VALUE_CHANNEL for hardware channels
> f779a92f7b69 wcn36xx: Use HW_VALUE_CHANNEL macro to get channel number
> 235b9ae0265b wcn36xx: Add accessor macro HW_VALUE_PHY for PHY settings
> fc4d4008f810 wcn36xx: Encode PHY mode for 80MHz channel in hw_value
> e042bc19aace wcn36xx: Set PHY into correct mode for 80MHz channel width

Just as a tip for the future, I think this patchset could have been
easily just one patch. Also I have noticed the same with other patchsets
from you. Splitting the patches to one function per patch is too much,
the recommend rule is "one logical change per patch".

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the wcn36xx mailing list