[PATCH v4 3/7] wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params()
kernel test robot
lkp at intel.com
Wed Sep 9 15:16:43 EDT 2020
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 160b351d75cb50a0dd2abf9b63e1891935aa9e4a]
url: https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Tidy-up-BSS-STA-config/20200910-011120
base: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: no previous prototype for 'wcn36xx_smd_set_bss_vht_params' [-Wmissing-prototypes]
150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:186:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_vht_params' [-Wmissing-prototypes]
186 | void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:208:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_ht_ldpc_params' [-Wmissing-prototypes]
208 | void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:233:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
233 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:249:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
249 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:1253:1: warning: no previous prototype for 'wcn36xx_smd_set_sta_params_v1' [-Wmissing-prototypes]
1253 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/smd.c:1387:6: warning: no previous prototype for 'wcn36xx_smd_set_bss_params' [-Wmissing-prototypes]
1387 | void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_bss_params':
>> drivers/net/wireless/ath/wcn36xx/smd.c:1395:40: warning: variable 'sta_params' set but not used [-Wunused-but-set-variable]
1395 | struct wcn36xx_hal_config_sta_params *sta_params;
| ^~~~~~~~~~
# https://github.com/0day-ci/linux/commit/1c12f515815cc2fa84d00b7c6aa77bf5dc5f1d20
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Tidy-up-BSS-STA-config/20200910-011120
git checkout 1c12f515815cc2fa84d00b7c6aa77bf5dc5f1d20
vim +/wcn36xx_smd_set_bss_params +1387 drivers/net/wireless/ath/wcn36xx/smd.c
1386
> 1387 void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn,
1388 struct ieee80211_vif *vif,
1389 struct ieee80211_sta *sta,
1390 const u8 *bssid,
1391 bool update,
1392 struct wcn36xx_hal_config_bss_params *bss)
1393 {
1394 struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
> 1395 struct wcn36xx_hal_config_sta_params *sta_params;
1396
1397 sta_params = &bss->sta;
1398
1399 WARN_ON(is_zero_ether_addr(bssid));
1400
1401 memcpy(&bss->bssid, bssid, ETH_ALEN);
1402
1403 memcpy(bss->self_mac_addr, vif->addr, ETH_ALEN);
1404
1405 if (vif->type == NL80211_IFTYPE_STATION) {
1406 bss->bss_type = WCN36XX_HAL_INFRASTRUCTURE_MODE;
1407
1408 /* STA */
1409 bss->oper_mode = 1;
1410 bss->wcn36xx_hal_persona = WCN36XX_HAL_STA_MODE;
1411 } else if (vif->type == NL80211_IFTYPE_AP ||
1412 vif->type == NL80211_IFTYPE_MESH_POINT) {
1413 bss->bss_type = WCN36XX_HAL_INFRA_AP_MODE;
1414
1415 /* AP */
1416 bss->oper_mode = 0;
1417 bss->wcn36xx_hal_persona = WCN36XX_HAL_STA_SAP_MODE;
1418 } else if (vif->type == NL80211_IFTYPE_ADHOC) {
1419 bss->bss_type = WCN36XX_HAL_IBSS_MODE;
1420
1421 /* STA */
1422 bss->oper_mode = 1;
1423 } else {
1424 wcn36xx_warn("Unknown type for bss config: %d\n", vif->type);
1425 }
1426
1427 if (vif->type == NL80211_IFTYPE_STATION)
1428 wcn36xx_smd_set_bss_nw_type(wcn, sta, bss);
1429 else
1430 bss->nw_type = WCN36XX_HAL_11N_NW_TYPE;
1431
1432 bss->short_slot_time_supported = vif->bss_conf.use_short_slot;
1433 bss->lla_coexist = 0;
1434 bss->llb_coexist = 0;
1435 bss->llg_coexist = 0;
1436 bss->rifs_mode = 0;
1437 bss->beacon_interval = vif->bss_conf.beacon_int;
1438 bss->dtim_period = vif_priv->dtim_period;
1439
1440 wcn36xx_smd_set_bss_ht_params(vif, sta, bss);
1441
1442 bss->oper_channel = WCN36XX_HW_CHANNEL(wcn);
1443
1444 if (conf_is_ht40_minus(&wcn->hw->conf))
1445 bss->ext_channel = IEEE80211_HT_PARAM_CHA_SEC_BELOW;
1446 else if (conf_is_ht40_plus(&wcn->hw->conf))
1447 bss->ext_channel = IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
1448 else
1449 bss->ext_channel = IEEE80211_HT_PARAM_CHA_SEC_NONE;
1450
1451 bss->reserved = 0;
1452
1453 /* wcn->ssid is only valid in AP and IBSS mode */
1454 bss->ssid.length = vif_priv->ssid.length;
1455 memcpy(bss->ssid.ssid, vif_priv->ssid.ssid, vif_priv->ssid.length);
1456
1457 bss->obss_prot_enabled = 0;
1458 bss->rmf = 0;
1459 bss->max_probe_resp_retry_limit = 0;
1460 bss->hidden_ssid = vif->bss_conf.hidden_ssid;
1461 bss->proxy_probe_resp = 0;
1462 bss->edca_params_valid = 0;
1463
1464 /* FIXME: set acbe, acbk, acvi and acvo */
1465
1466 bss->ext_set_sta_key_param_valid = 0;
1467
1468 /* FIXME: set ext_set_sta_key_param */
1469
1470 bss->spectrum_mgt_enable = 0;
1471 bss->tx_mgmt_power = 0;
1472 bss->max_tx_power = WCN36XX_MAX_POWER(wcn);
1473 bss->action = update;
1474
1475 vif_priv->bss_type = bss->bss_type;
1476 }
1477
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 61672 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/wcn36xx/attachments/20200910/8d1a2fcf/attachment-0001.gz>
More information about the wcn36xx
mailing list