[PATCH v3 0/2] wcn36xx: Extend V1 data-structures
Bryan O'Donoghue
bryan.odonoghue at linaro.org
Tue Sep 8 14:24:26 EDT 2020
This series is one in a set of seven to add support for wcn3680 at 802.11ac
data-rates.
In order to pass VHT parameters to the firmware, we need to extend the
parameter data-structure. In the V2 series, this was accomplished in two
patches.
https://lore.kernel.org/linux-wireless/20200829033908.2167689-13-bryan.odonoghue@linaro.org/T/#u
https://lore.kernel.org/linux-wireless/20200829033908.2167689-2-bryan.odonoghue@linaro.org/T/#u
However since I was rebasing this series anyway I thought it would be a
better idea to do the conversion in one go, so that if someone is
rebasing/bisecting in the future every single patch will still be
functional and testable on wcn3620. If the data-structure is extended and
then the code is subsequently updated, then the patches in-between the
data-structure update and the code update will not be testable on hardware.
As a result I've opted to front-load the conversion. The first patch is
atomic with respect to ongoing functionality on wcn3620, which I think is a
better result for not much extra code.
The eventual enabling for wcn3680 comes in a later patch in a later set.
For a similar reason I thought it best to front-load the conversion to
using the extended V1 data-structure for storing parameters internal to the
driver.
Bryan O'Donoghue (2):
wcn36xx: Add VHT fields to parameter data structures
wcn36xx: Use V1 data structure to store supported rates
drivers/net/wireless/ath/wcn36xx/hal.h | 14 +++++++++++++-
drivers/net/wireless/ath/wcn36xx/smd.c | 7 +++++--
drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 2 +-
3 files changed, 19 insertions(+), 4 deletions(-)
--
2.27.0
More information about the wcn36xx
mailing list