[RFC 1/2] Revert "wcn36xx: Pad TIM PVM if needed"

Yeoh Chun-Yeow yeohchunyeow at gmail.com
Fri Mar 7 00:02:04 EST 2014


> This would need a better commit log, but let me at least add some
> context for others' benefit: I found the patch in question broke
> mesh beaconing, i.e.  no beacons at all are sent after the change.
>
> But, mesh is doing some weird things with the TIM offset to
> avoid having the firmware update it, so it could be mesh-specific
> breakage and perhaps a workaround for mesh vif is needed.

Yes, we just simply ignore the TIM.

I take a look on the changes on wcn36xx_smd_send_beacon and found out
that there is also a new member (beacon_length6) added in the
wcn36xx_hal_send_beacon_req_msg.
wcn36xx relies on ieee80211_beacon_get_tim. For mesh, the tim_off is
always 0 and msg_body.beacon_length may be wrong with pad and pvm_len
wrongly calculated.

Perhaps, we can just set pad = 0 if it is mesh interface for the work
around such as follow:
https://github.com/chunyeow/wcn36xx/commit/54dd5deae8a85c02473d21d6c722bb8a4a0e7139

---
Chun-Yeow



More information about the wcn36xx mailing list