[PATCH 3/5] wcn36xx: set initial edca queue parameters

Bob Copeland me at bobcopeland.com
Tue Mar 4 09:36:21 EST 2014


On Tue, Mar 04, 2014 at 08:48:43AM +0000, Eugene Krasnikov wrote:
> In general the idea is good, but there some minor questions:
> 
> 1) Did you get these numbers from prima driver? Just for my
> information could you please share where exactly in prima did you find
> them? Should we have some defines for them?

So, I got them from the upd_edca_params message from a prima
dump -- offhand I'm not sure where that lives in the code.

Yes, it would be better to use defines for the values.  But
perhaps we should just drop this one and I'll do a follow-on
patch that configures it through ops->conf_tx.

> 2) Did you test EDCA? If EDCA is working should we mention that on
> wcn36xx wiki page in here
> http://wireless.kernel.org/en/users/Drivers/wcn36xx#Working ?

Not as such - for one thing, sta.wmmEnabled is always false in
STA mode, so I don't know if it will work as-is.  But I think
it'd be relatively easy to fix up the missing bits.

-- 
Bob Copeland %% www.bobcopeland.com



More information about the wcn36xx mailing list