[PATCH 3/5] wcn36xx: set initial edca queue parameters

Eugene Krasnikov k.eugene.e at gmail.com
Tue Mar 4 03:48:43 EST 2014


In general the idea is good, but there some minor questions:

1) Did you get these numbers from prima driver? Just for my
information could you please share where exactly in prima did you find
them? Should we have some defines for them?
2) Did you test EDCA? If EDCA is working should we mention that on
wcn36xx wiki page in here
http://wireless.kernel.org/en/users/Drivers/wcn36xx#Working ?

2014-03-03 20:45 GMT+00:00 Bob Copeland <me at bobcopeland.com>:
> Configure queues when we join a BSS.
>
> Signed-off-by: Bob Copeland <bob at cozybit.com>
> ---
>  smd.c |   27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/smd.c b/smd.c
> index 88aa84b..68fece2 100644
> --- a/smd.c
> +++ b/smd.c
> @@ -1309,9 +1309,32 @@ int wcn36xx_smd_config_bss(struct wcn36xx *wcn, struct ieee80211_vif *vif,
>         bss->max_probe_resp_retry_limit = 0;
>         bss->hidden_ssid = vif->bss_conf.hidden_ssid;
>         bss->proxy_probe_resp = 0;
> -       bss->edca_params_valid = 0;
> +       bss->edca_params_valid = 1;
> +
> +       bss->acbe.aci.aifsn = 3;
> +       bss->acbe.aci.aci = 0;
> +       bss->acbe.cw.min = 4;
> +       bss->acbe.cw.max = 10;
> +       bss->acbe.txop_limit = 0;
> +
> +       bss->acbk.aci.aifsn = 7;
> +       bss->acbk.aci.aci = 1;
> +       bss->acbk.cw.min = 4;
> +       bss->acbk.cw.max = 10;
> +       bss->acbk.txop_limit = 0;
> +
> +       bss->acvi.aci.aifsn = 2;
> +       bss->acvi.aci.aci = 2;
> +       bss->acvi.cw.min = 3;
> +       bss->acvi.cw.max = 4;
> +       bss->acvi.txop_limit = 93;
> +
> +       bss->acvo.aci.aifsn = 2;
> +       bss->acvo.aci.aci = 3;
> +       bss->acvo.cw.min = 2;
> +       bss->acvo.cw.max = 3;
> +       bss->acvo.txop_limit = 46;
>
> -       /* FIXME: set acbe, acbk, acvi and acvo */
>
>         bss->ext_set_sta_key_param_valid = 0;
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx



-- 
Best regards,
Eugene



More information about the wcn36xx mailing list